Skip to content

Make initializeFirestore() idempotent #5280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2021
Merged

Make initializeFirestore() idempotent #5280

merged 5 commits into from
Aug 12, 2021

Conversation

hsubox76
Copy link
Contributor

Making all product initialize() functions idempotent.
See #5272

I don't see any existing tests for initializeFirestore() or getFirestore() and I'm a little unsure of how to set up a new test in this structure.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9c35ff7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore-exp

    Type Base (3871f26) Head (845df28) Diff
    browser 224 kB 224 kB +206 B (+0.1%)
    main 510 kB 511 kB +360 B (+0.1%)
    module 224 kB 224 kB +206 B (+0.1%)
    react-native 224 kB 225 kB +206 B (+0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 11, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (d46d84b) and head commit (fa6fa29).

@hsubox76 hsubox76 requested a review from Feiyang1 August 11, 2021 22:15
@hsubox76 hsubox76 force-pushed the ch-idempotent-firestore branch from cc05e0f to 991010c Compare August 11, 2021 23:00
@hsubox76 hsubox76 force-pushed the ch-idempotent-firestore branch from 991010c to bfbc873 Compare August 11, 2021 23:35
@hsubox76
Copy link
Contributor Author

CI seems to be flaky. Build and tests pass locally.

@hsubox76 hsubox76 merged commit b12abae into ch-idempotent Aug 12, 2021
@hsubox76 hsubox76 deleted the ch-idempotent-firestore branch August 12, 2021 21:47
@firebase firebase locked and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @Feiyang1 @schmidt-sebastian